Conversation
fwiesel
force-pushed
the
no-more-labels
branch
from
4d569b6 to
fd02a6d
Compare
Contributor
Author
|
Based on #213 |
fwiesel
force-pushed
the
no-more-labels
branch
2 times, most recently
from
1f95637 to
0ebd9b3
Compare
Contributor
|
I don't think we should allow a mix-configuration with maintenance-operator and without, it bloats unnecessary and makes the code much more error prone. I know it's painful to switch, but we should just rip of the band aid. |
fwiesel
force-pushed
the
no-more-labels
branch
3 times, most recently
from
59fa053 to
efa4675
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
When there is no maintenance-contoller profile the GardenerLifecycleController will now set the hypervisor cro maintenance field. For confirmation, it will look on the conditions. That renders the labels obsolete.
Contributor
Author
|
I've removed that part. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there is no maintenance-contoller profile the GardenerLifecycleController will now set the hypervisor cro maintenance field. For confirmation, it will look on the conditions.
That renders the labels obsolete.